Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net5.0 TFM may need to be cleared from some projects #9886

Open
heng-liu opened this issue Aug 7, 2020 · 3 comments · May be fixed by NuGet/NuGet.Client#6220
Open

net5.0 TFM may need to be cleared from some projects #9886

heng-liu opened this issue Aug 7, 2020 · 3 comments · May be fixed by NuGet/NuGet.Client#6220
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Signing Priority:2 Issues for the current backlog. TechDebt Technical debt Type:Engineering product/infrastructure work/not a customer bug/feature/DCR

Comments

@heng-liu
Copy link
Contributor

heng-liu commented Aug 7, 2020 •
edited
Loading

For now, we added net5.0 for the following projects,
src: (12)

Microsoft.Build.NuGetSdkResolver
NuGet.Build.Tasks
NuGet.Build.Tasks.Console
NuGet.CommandLine.Xplat
NuGet.Commands
NuGet.Credentials
NuGet.DependencyResolver.Core
NuGet.Packaging
NuGet.Packaging.Core
NuGet.ProjectModel
NuGet.Protocol
NuGet.Resolver

test: (23)

Microsoft.Build.NuGetSdkResolver.Tests
NuGet.Build.Tasks.Test
NuGet.Build.Tasks.Console.Test
NuGet.CommandLine.Xplat.Tests
NuGet.Commands.Test
NuGet.DependencyResolver.Core.Tests
NuGet.Packaging.Test
NuGet.ProjectModel.Test
NuGet.Protocol.Tests
NuGet.Resolver.Test
NuGet.Common.Test
NuGet.Build.Tasks.Pack.Test
NuGet.Configuration.Test
NuGet.Shared.Tests
NuGet.Versioning.Test
Dotnet.Integration.Test
NuGet.Core.FuncTest
NuGet.Packaging.FuncTest
NuGet.Commands.FuncTest
NuGet.Protocol.FuncTest
NuGet.XPlat.FuncTest
TestablePlugin
Test.Utility

We need to check if the above projects need the net5.0.
Thanks for @zivkan 's suggestion, that, the projects without #if NET5_0 and #if IS_SIGNING_SUPPORTED, the netstandard2.0 and net5.0 assemblies may be the same.
We should also consider the "entry point" project, like NuGet.Build.Tasks, even if there is no #if, we still need to add net5.0 to it.
@zkat zkat added Type:Engineering product/infrastructure work/not a customer bug/feature/DCR Priority:2 Issues for the current backlog. labels Aug 10, 2020
@nkolev92 nkolev92 mentioned this issue Jan 12, 2022
Merged
8 tasks
@heng-liu heng-liu added the Category:Quality Week Issues that should be considered for quality week label Oct 24, 2022
@heng-liu heng-liu self-assigned this Oct 24, 2022
This was referenced Mar 16, 2023
Closed
Merged
@nkolev92
Copy link
Member

I've done some work in #12489.

I didn't remove everything :)

@nkolev92
Copy link
Member

nkolev92 commented Sep 27, 2023 •
edited
Loading

Here's a quick analysis

test: (23)

  • Microsoft.Build.NuGetSdkResolver.Tests
  • NuGet.Build.Tasks.Test
  • NuGet.Build.Tasks.Console.Test
  • NuGet.CommandLine.Xplat.Tests
  • NuGet.Commands.Test
  • NuGet.DependencyResolver.Core.Tests
  • NuGet.Packaging.Test
  • NuGet.ProjectModel.Test
  • NuGet.Protocol.Tests
  • NuGet.Resolver.Test
  • NuGet.Common.Test
  • NuGet.Build.Tasks.Pack.Test
  • NuGet.Configuration.Test
  • NuGet.Shared.Tests
  • NuGet.Versioning.Test
  • Dotnet.Integration.Test
  • NuGet.Core.FuncTest
  • NuGet.Packaging.FuncTest
  • NuGet.Commands.FuncTest
  • NuGet.Protocol.FuncTest
  • NuGet.XPlat.FuncTest
  • TestablePlugin
  • Test.Utility

@nkolev92
Copy link
Member

image

Provides visibility of the graphs and makes a few things easier.

@heng-liu heng-liu removed their assignment Oct 7, 2023
@nkolev92 nkolev92 added the TechDebt Technical debt label Dec 8, 2023
@nkolev92 nkolev92 mentioned this issue Dec 8, 2023
Open
@nkolev92 nkolev92 self-assigned this Apr 1, 2024
@nkolev92 nkolev92 linked a pull request Jan 11, 2025 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Signing Priority:2 Issues for the current backlog. TechDebt Technical debt Type:Engineering product/infrastructure work/not a customer bug/feature/DCR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Target net8.0 only NuGet/NuGet.Client
3 participants
@zkat @nkolev92 @heng-liu