Fix invalid target framework error for Solution restore

[martinrrm]

Bug

Fixes: NuGet/Home#13772

Description

There is a difference in behavior when doing a restore in Solution vs Project with an invalid target framework in the <TargetFramework> tag. When doing it in the project Level, sdk will run a validation before doing restore in https://github.com/dotnet/sdk/blob/5ab26633bdf4676efa25140a31a3d6182efb02f9/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets#L92.

The problem is that Solution level does not this validation (since it doesn't run a restore for each project) and will fail with

...\Current\bin\NuGet.targets(169,5): error : Sequence contains no matching element [<repo>\dirs.proj]

This PR adds a validation and return the same error message as the project level. Currently, I decided to error with a NuGet error but we could also add NETSDK1046 in the error message.

PR Checklist

• Meaningful title, helpful description and a linked NuGet/Home issue
• Added tests
• Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

[nkolev92]

There's some test failures that seem like actual failures.
It's also worth calling out in the description that this is only a CLI problem in the PR description and that VS errors are way better.

[nkolev92]

Throwing from here probably leads to a bad failure in NuGet.exe?

In general, NuGet.exe expects a dg spec to create an this fails that.

Can you double check NuGet.exe?

[jgonz120]

Suggested change

	public void GetOriginalTargetFramework_WhenTargetFramworkSpecified_HasCorrectTargetFramework(string targetFrameworks)
	public void GetOriginalTargetFramework_WhenMultipleTargetFramworkSpecified_ThrowRestoreCommandException(string targetFrameworks)

Might want to change the name of this test.

[microsoft-github-policy-service]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.