Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package dependencies to 8.x and improve shims failed load #10226

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Oct 16, 2024

This takes a feature branch from @agr and adds a couple more fixes on top.

Summary of changes

  • Bring existing Microsoft.* dependencies up to 8.x
  • Fix binding redirects in CDNRedirect (this app is currently broken)
  • Fix binding redirects in NuGetGallery, needed due to package updates
  • Bring test fixes for logging package update (thanks @agr)
  • Improve error logging when our shims layer fails to load (the Loader exceptions show Fusion logs for the failed load, these show up in the error logs section in App Service Kudu).

This change needs to be carried to our shims also.

@joelverhagen joelverhagen requested a review from a team as a code owner October 16, 2024 18:10
@joelverhagen joelverhagen changed the title Jver mext Update package dependencies to 8.x and improve shims failed load Oct 16, 2024
jimmylewis
jimmylewis previously approved these changes Oct 16, 2024
@agr
Copy link
Contributor

agr commented Oct 16, 2024

Show me successful deployment!

@joelverhagen
Copy link
Member Author

Show me successful deployment!

image

But sign-in is not working in dev or main right now, so I'll looking into that too.

@joelverhagen joelverhagen merged commit 6211dfb into dev Oct 17, 2024
2 checks passed
@joelverhagen joelverhagen deleted the jver-mext branch October 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants