bird: config check fails if roagen is enabled #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelCoding
reviewed
Dec 1, 2024
fpletz
force-pushed
the
fix-roagen-bird-config-check
branch
2 times, most recently
from
ac2dc50 to
9e89f9e
Compare
MarcelCoding
reviewed
Dec 1, 2024
The generated roa configs are not available at build time. That causes the config check to fail and needs patching to point to stubs to succeed.
The action is not designed to work on pull requests.
fpletz
force-pushed
the
fix-roagen-bird-config-check
branch
from
9e89f9e to
f01473c
Compare
astro
reviewed
Dec 1, 2024
| @@ -4,7 +4,6 @@ on: | |||
| push: | |||
| branches: [ main ] | |||
| tags: [ '*' ] | |||
| pull_request: | |||
There was a problem hiding this comment.
It failed previously: https://github.com/NuschtOS/dn42.nix/actions/runs/12108631763/job/33756971217?pr=50#step:5:99
Only seems to work on the same repo?
There was a problem hiding this comment.
I think the idea was that it PRs your repo with the fix but that doesn't seem to work as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated roa configs are not available at build time. That causes theconfig check to fail and needs patching to point to stubs to succeed.