[15.0][ADD] website_sale_product_publish_date

[AungKoKoLin1997]

The purpose of this module is to publish and unpublish products in ecommerce with timeframe.
@qrtl

[pedrobaeza]

Why not modifying the controller to add a condition to the product search the same as website_blog does?

The publish date can be by website, but that's something for the roadmap I think.

Finally, I think it can be called website_sale_product_publish_date.

[AungKoKoLin1997]

Why not modifying the controller to add a condition to the product search the same as website_blog does?

@pedrobaeza I don't get your point. What part of controller are your mentioning in website_blog?

[pedrobaeza]

https://github.com/odoo/odoo/blob/ce0cd0ed7474bfa397675cad053f9751cce74be8/addons/website_blog/controllers/main.py#L85

[AungKoKoLin1997]

The purpose of this module is to publish/publish the product with scheduler, not for reflecting actual publish_date via website or manual. For the product search, this module will not hide any product.(For instance, products may not have expected_publish_date but user can manually publish and will show in e-commerce. They only care about website_publish.). The module intends for the uses who want to publish some products that have a specific time to be published. So, they don't need to be updated manually even if it is late at night.

[kanda999]

Functional review

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[yostashiro]

@AungKoKoLin1997 As we just talked, can you please look into the possibility of extending website._search_exact() instead of using cron?

https://github.com/odoo/odoo/blob/a923bc42b5d1c856e02215e05cfcea47a9685f48/addons/website/models/website.py#L1608-L1633

[yostashiro]

We should do this only on the product model.

It may also be safer to check website_published is included in domain_list.

[AungKoKoLin1997]

https://github.com/odoo/odoo/blob/ce0cd0ed7474bfa397675cad053f9751cce74be8/addons/website_blog/controllers/main.py#L85

@pedrobaeza Thanks for the suggestion and for pointing that out.

[yostashiro]

Code review.

[yostashiro]

Suggested change

	publish_domain = self._get_publish_date_domain()
	combined_domain = expression.AND([base_domain, publish_domain])
	publish_date_domain = self._get_publish_date_domain()
	combined_domain = expression.AND([base_domain, publish_date_domain])

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[yostashiro]

@AungKoKoLin1997 Can you please fix the commit message reflecting the module name.

[kanda999]

Functional review