Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG+IMP] website_account_fiscal_position_partner_type #830

Conversation

manuelregidor
Copy link

@manuelregidor manuelregidor commented Aug 23, 2023

MIG: Standard migration
IMP: Show fiscal_position_type in user detals view in portal, show fiscal_position_type in registration screen, avoid changing fiscal_position_type under certain circumstances.

@manuelregidor manuelregidor force-pushed the 15.0-mig-website_account_fiscal_position_partner_type branch from fbbbb19 to 52dd152 Compare August 23, 2023 09:02
@manuelregidor manuelregidor changed the title [15.0][MIG] website_account_fiscal_position_partner_type [15.0][MIG+IMP] website_account_fiscal_position_partner_type Aug 24, 2023
@manuelregidor manuelregidor force-pushed the 15.0-mig-website_account_fiscal_position_partner_type branch 3 times, most recently from 9e82a50 to 1885075 Compare August 24, 2023 11:15
@manuelregidor
Copy link
Author

Copy link

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When registering, the company's default option does not work. Could you check it?
Selección_042

@manuelregidor manuelregidor force-pushed the 15.0-mig-website_account_fiscal_position_partner_type branch from 1885075 to a6f1642 Compare September 4, 2023 06:48
@manuelregidor
Copy link
Author

When registering, the company's default option does not work. Could you check it? Selección_042

@ValentinVinagre Done

Copy link

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@manuelregidor manuelregidor force-pushed the 15.0-mig-website_account_fiscal_position_partner_type branch 4 times, most recently from 0509f88 to b1350d2 Compare September 13, 2023 15:40
@HaraldPanten
Copy link

@pedrobaeza @chienandalu how come these tests fail for the OCB but the others in the FIX (20 minutes ago) have been successful? 😂

We'll have a look and check it.

@chienandalu
Copy link
Member

@pedrobaeza @chienandalu how come these tests fail for the OCB but the others in the FIX (20 minutes ago) have been successful? 😂

We'll have a look and check it.

Maybe a random fail. I'd try again

…tion to 15.0, show fiscal position type in additional portal views
@manuelregidor manuelregidor force-pushed the 15.0-mig-website_account_fiscal_position_partner_type branch from b1350d2 to bca696c Compare September 13, 2023 16:10
@HaraldPanten
Copy link

@pedrobaeza Finally it's done.

Could you merge, please?

@pedrobaeza
Copy link
Member

/ocabot migration website_account_fiscal_position_partner_type
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 13, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-830-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 13, 2023
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 13, 2023
41 tasks
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-830-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-830-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 13, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-830-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-830-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 31ac102 into OCA:15.0 Sep 13, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 22ab0f0. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten
Copy link

Thanks Pedro. It was a resistant one.

@HaraldPanten HaraldPanten deleted the 15.0-mig-website_account_fiscal_position_partner_type branch September 13, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants