Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [FW] [IMP] fieldservice_sale: Only invoice invoiceable fsm order #1314

Open
wants to merge 8 commits into
base: 17.0
Choose a base branch
from
Open

[17.0] [FW] [IMP] fieldservice_sale: Only invoice invoiceable fsm order #1314

wants to merge 8 commits into from

Conversation

ivantodorovich
Copy link

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @wolfhall, @brian10048,
some modules you are maintaining are being modified, check this out!

@ivantodorovich
[FIX] fieldservice_account: _get_invoiceable_stage domain
d7ca69c
@ivantodorovich
[FIX] fieldservice_account_analytic: add demo data for tests
24293a2 
This fixes unit tests in other modules like `fieldservice_sale`, which don't
directly depend on this one.

e.g.:
```
  File "/opt/odoo/odoo/api.py", line 415, in _model_create_multi
    return create(self, arg)
  File "/__w/field-service/field-service/fieldservice_account_analytic/models/account_move.py", line 22, in create
    raise ValidationError(
odoo.exceptions.ValidationError: No analytic account set on the order's Location.
```
@ivantodorovich ivantodorovich marked this pull request as ready for review February 3, 2025 18:25
gurneyalex
gurneyalex approved these changes Feb 4, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@vvrossem vvrossem vvrossem approved these changes

@SilvioC2C SilvioC2C SilvioC2C approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ivantodorovich @OCA-git-bot @gurneyalex @vvrossem @SilvioC2C @paradoxxxzero @mourad-ehm