-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] fieldservice_availability: New module fieldservice_availability #1318
base: 15.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, Can you please explain a bit about the use case for this module ? FYI, in fsm_recurring you can create a rrule (with the festive dates) and use it as an exclusion. |
Hi @hparfr, thank you for your feedback.
Regarding the rrules from Let me know what you think about this. |
I see the need to have something simplier than rrule and not refactor all the code. Be careful with the wording about "festive". Because, in security agents business or food catering... the festive day is a working day. I have one use case with cleaning in shops. They need to know "specials" days like start of the sales period, etc. some time is it means they should not come (because the shop is too crowded) sometime it's the opposit: you need more cleaning. |
I see your point @hparfr about using the term "festive" -- it's clear that it may not work universally across all industries. Would terms like "special days", "schedule exceptions", "service modifications" or "availability blocks" work better in this context? I'm aiming for terminology that can cover a range of use cases, where these days could either be times to avoid service or require additional services, as you suggested with the shop example. It would be great to hear your thoughts on which term you think works best, or if you have other suggestions that might better capture this concept for different business needs. Looking forward to your input! |
I'm not a native english speaker so I do not know the good terms. May be @brian10048 can help us on this. May be 3 states can be good : Open / Unkown / Closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat and code review
I understand the festive day is meant to represent a day where the schedule is generally unavailable. Similar to a public holiday in Odoo Time Off. I suggest I had not thought of the concept requiring additional workloads. This would be like a Stress day in Odoo Time Off. |
f534da7
to
52db1f5
Compare
Thank you for your suggestions @brian10048! I've implemented the changes to use |
52db1f5
to
cae1d18
Compare
Hi @brian10048 @max3903, is this ready to merge? Thank you in advance! |
cae1d18
to
7b9da38
Compare
This module defines blackout days (non-operational days), stress days (high-demand periods), and delivery time ranges for field service operations. It provides the necessary models to store this information, which can be used by other modules to manage scheduling, availability, and workload adjustments.
This is a technical module and does not provide functionality on its own. Extend this module to integrate availability management into field service workflows.
cc https://github.com/APSL 166637
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review