Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] fieldservice_stock: Add setting to enable/disable auto-validation of pickings on FSM order completion #1323

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Feb 17, 2025

Add a setting fieldservice_stock.auto_validate_pickings to enable automatic validation of related pickings when completing an FSM order. If a related picking lacks sufficient stock, an error is raised to inform the user.

cc https://github.com/APSL 167266

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @smangukiya, @wolfhall, @brian10048,
some modules you are maintaining are being modified, check this out!

@ppyczko ppyczko changed the title [IMP] fieldservice_stock: Add setting to enable/disable auto-validation of pickings on FSM order completion [15,0][IMP] fieldservice_stock: Add setting to enable/disable auto-validation of pickings on FSM order completion Feb 17, 2025
@ppyczko ppyczko changed the title [15,0][IMP] fieldservice_stock: Add setting to enable/disable auto-validation of pickings on FSM order completion [15.0][IMP] fieldservice_stock: Add setting to enable/disable auto-validation of pickings on FSM order completion Feb 17, 2025
@ppyczko ppyczko force-pushed the 15.0-imp-fieldservice_stock-autovalidate-pickings branch from 61284b3 to ca2bca6 Compare February 17, 2025 12:51
@ppyczko ppyczko marked this pull request as ready for review February 17, 2025 12:56
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@ppyczko ppyczko force-pushed the 15.0-imp-fieldservice_stock-autovalidate-pickings branch 3 times, most recently from eeb37db to 42ffd94 Compare February 18, 2025 08:37
@ppyczko ppyczko force-pushed the 15.0-imp-fieldservice_stock-autovalidate-pickings branch from 42ffd94 to 68fc799 Compare February 18, 2025 09:21
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants