Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [MIG] helpdesk_mgmt_stage_validation: Migration to 17.0 #661

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from
Open

[17.0] [MIG] helpdesk_mgmt_stage_validation: Migration to 17.0 #661

wants to merge 3 commits into from

Conversation

ivantodorovich
Copy link

@ivantodorovich ivantodorovich commented Nov 27, 2024 •
edited
Loading

Superseeds:

Reason:

  • ✅ Dropped the merged test-requirement
  • ✅ Fix misuse of f-strings in gettext translation (see comment)
  • 🧹 Squashed administrative commits

@ivantodorovich ivantodorovich mentioned this pull request Nov 27, 2024
Open
@ivantodorovich ivantodorovich force-pushed the 17.0-mig-helpdesk_mgmt_stage_validation branch from ccfe2e1 to 30960b3 Compare November 27, 2024 18:51
Camille0907
Camille0907 approved these changes Nov 28, 2024
View reviewed changes
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration LGTM, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camille0907 Camille0907 Camille0907 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivantodorovich @Camille0907 @BojanOD @mymage @yankinmax