-
-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] hr_maintenance_workspace #1115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see in-line comments about code improvements and automatically generating readme. Also, please add a few tests.
Thank you!
Hello @valentincastravete are you going to made the changes suggested in the review? |
Hi @nimarosa Yes I will do, sorry about my absence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Technical Review
@etobella Could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, I would propose to change the name of the module to hr_maintenance_workspace
Module name and its references modified |
Hi @angelmoya , can you review and remove the tag "needs fixing" please? |
@valentincastravete Can you squash all your commits in a single commit and push force? this will allow us to use runboat too 😄 |
Hi, there you go! |
Do it again please, I just fixed the pre-commit 😢 |
Done! @etobella |
Now you need to fix the precommit from your side, as the error comes from your code 😄 |
Code fixed 😄 |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@etobella |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at bc997dd. Thanks a lot for contributing to OCA. ❤️ |
@etobella |
HR Maintenance Workspace
Allows to associate employees and equipments to workspaces.
Table of contents
Implemented Uses
Employees
Workspaces