Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] hr_maintenance_workspace #1115

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[14.0][ADD] hr_maintenance_workspace #1115

merged 1 commit into from
Mar 6, 2024

Conversation

valentincastravete
Copy link

@valentincastravete valentincastravete commented May 18, 2022

HR Maintenance Workspace

Allows to associate employees and equipments to workspaces.

Table of contents

Implemented Uses

Employees

  • Employees can be assigned to workspaces.

Workspaces

  • Each workspace has employees and equipment asigned to it. It represents a real workspace.

Copy link

@mtelahun mtelahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see in-line comments about code improvements and automatically generating readme. Also, please add a few tests.
Thank you!

hr_maintenance_workspaces/models/equipment.py Outdated Show resolved Hide resolved
hr_maintenance_workspaces/models/workspace.py Outdated Show resolved Hide resolved
hr_maintenance_workspaces/README.rst Outdated Show resolved Hide resolved
hr_maintenance_workspaces/static/description/index.html Outdated Show resolved Hide resolved
@nimarosa
Copy link
Contributor

nimarosa commented Sep 7, 2022

Hello @valentincastravete are you going to made the changes suggested in the review?

@valentincastravete
Copy link
Author

Hello @valentincastravete are you going to made the changes suggested in the review?

Hi @nimarosa Yes I will do, sorry about my absence.

Copy link

@JorgeQuinteros JorgeQuinteros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Technical Review

@valentincastravete
Copy link
Author

@etobella Could you review please?

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, I would propose to change the name of the module to hr_maintenance_workspace

@valentincastravete
Copy link
Author

Just one comment, I would propose to change the name of the module to hr_maintenance_workspace

Module name and its references modified

@valentincastravete valentincastravete changed the title [14.0][ADD] hr_maintenance_workspaces [14.0][ADD] hr_maintenance_workspace Jun 7, 2023
@valentincastravete
Copy link
Author

@nimarosa @mtelahun Could you review please? Thanks!

@valentincastravete
Copy link
Author

Hi @angelmoya , can you review and remove the tag "needs fixing" please?

@etobella
Copy link
Member

@valentincastravete Can you squash all your commits in a single commit and push force? this will allow us to use runboat too 😄

@valentincastravete
Copy link
Author

valentincastravete commented Oct 30, 2023

@valentincastravete Can you squash all your commits in a single commit and push force? this will allow us to use runboat too 😄

Hi, there you go!
@etobella

@etobella
Copy link
Member

Do it again please, I just fixed the pre-commit 😢

@valentincastravete
Copy link
Author

Do it again please, I just fixed the pre-commit 😢

Done! @etobella

@etobella
Copy link
Member

Now you need to fix the precommit from your side, as the error comes from your code 😄

@valentincastravete
Copy link
Author

Now you need to fix the precommit from your side, as the error comes from your code 😄

Code fixed 😄

Copy link

github-actions bot commented Mar 3, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 3, 2024
@valentincastravete
Copy link
Author

valentincastravete commented Mar 6, 2024

@etobella
Hi there! Could you please mention someone with merge permission on this PR so it can be finally merged or modified if really needed?
Thanks!

@etobella
Copy link
Member

etobella commented Mar 6, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1115-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f84b602 into OCA:14.0 Mar 6, 2024
10 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bc997dd. Thanks a lot for contributing to OCA. ❤️

@valentincastravete
Copy link
Author

@etobella
Thanks a lot!!
Hope this module helps a lot of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants