Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] hr_employee_firstname: rename hooks file #1289

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

andreagidaltig
Copy link
Contributor

@andreagidaltig andreagidaltig commented Nov 6, 2023

Apply guidelines on name of hooks file.

@andreagidaltig andreagidaltig force-pushed the 16.0-hooks-andreagidaltig branch from 209646b to 709a43c Compare November 6, 2023 19:44
@andreagidaltig
Copy link
Contributor Author

Hi @luisg123v could you review this please?

@luisg123v
Copy link
Contributor

Remove the maintainers part from description.

@andreagidaltig andreagidaltig force-pushed the 16.0-hooks-andreagidaltig branch from 709a43c to 5acb199 Compare November 6, 2023 20:27
Apply guidelines on name of hooks file.
@andreagidaltig andreagidaltig force-pushed the 16.0-hooks-andreagidaltig branch from 5acb199 to 0b0bb35 Compare November 6, 2023 20:28
@andreagidaltig
Copy link
Contributor Author

I just updated this, could you review it, please? @luisg123v

Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moylop260 could you review/merge, please?

Copy link

@moylop260 moylop260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moylop260
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1289-by-moylop260-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 87e5e69 into OCA:16.0 Nov 8, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cb96f02. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants