[17.0][MIG] hr_employee_lastnames: Migration to 17.0 #1315

andreagidaltig · 2023-11-16T22:01:45Z

Rename module from hr_employee_lastnames → hr_employee_second_lastname
in order to be consistent with partner_second_lastname module.
Fix some new lints.
Update incoming parameters of post_init_hook method since cr, registry
were replaced by env in [1].
Introduce the use of new onchange method [2] (renamed in [3]) to
return the fields specification from a view description.

[1] odoo/odoo@b4a7996
[2] odoo/odoo@f5e6494

andreagidaltig · 2023-11-16T22:26:35Z

Hi @luisg123v could you review this please?

cc. @luistorresm

FernandoRomera · 2023-11-20T08:18:34Z

@andreagidaltig
Could we change the name of the module to synchronize it with partner_second_lastname?.

Then "hr_employee_lastnames" -> "hr_employee_second_lastname"

FrancoMaxime · 2023-11-27T16:36:05Z

hr_employee_lastnames/models/hr_employee.py

+            else:
+                lastname2 = self.lastname2
+            vals["name"] = self._get_name_lastnames(lastname, firstname, lastname2)
+        elif vals.get("name"):


Hi @andreagidaltig, i created a PR fixing some issues in the v14 module ( #1283) I could reproduce the bug on the runboat v17.
To reproduce you can create an employee with a first name equals to " Name 1 Name 2 name 3" and a lastname equals to "name4" if you export the data (including the external_id) and importing again the data, the name will be changed.

Could you fix it or cherry pick my commit? Thanks

@FrancoMaxime since your PR is not merged yet, it shouldn't be included in the migration (because it's still subject to changes).

@luisg123v Thanks, I hadn’t thought of that!

luisg123v · 2023-11-27T20:45:28Z

@FernandoRomera

Could we change the name of the module to synchronize it with partner_second_lastname?.

Not sure if that's a good idea. That will "break" systems being migrated from previous versions, because the old module would result uninstallable and the new one not installed.

luisg123v · 2023-11-27T20:56:53Z

hr_employee_second_lastname/__init__.py

@@ -0,0 +1,2 @@
+from . import models
+from .hooks import post_init_hook


Could you rename hooks file in the previous version, please?

FernandoRomera · 2023-12-01T09:00:27Z

@FernandoRomera

Could we change the name of the module to synchronize it with partner_second_lastname?.

Not sure if that's a good idea. That will "break" systems being migrated from previous versions, because the old module would result uninstallable and the new one not installed.

@luisg123v
Don't worry, there is already a procedure for this in OpenUpgrade.

If you want we can propose the PR in OpenUpgrade.

apriory.py in OpenUpgrade

Renamed modules is a mapping from old module name to new module name
renamed_modules = {
...
# OCA/hr
"hr_employee_lastnames": "hr_employee_second_lastname",
...

This PR is a example: https://github.com/OCA/OpenUpgrade/pull/4246/files

luisg123v · 2023-12-01T15:19:46Z

Got it. I think module renaming should be on a separate commit, though, before running pre-commit

@moylop260 what do you think about renaming the module?

moylop260 · 2023-12-01T15:55:03Z

I'm not a fan to rename modules

But I don't have the enough context to do it

Consider that you will need to change all the xmlids and you will need to change all the depends from the manifest of modules using this module

FernandoRomera · 2023-12-01T18:00:33Z

Don't worry, there is already a procedure for this in OpenUpgrade.

@moylop260
Don't worry, there is already a procedure for all changes in OpenUpgrade.

I'm not a fan to rename modules

But I don't have the enough context to do it

Consider that you will need to change all the xmlids and you will need to change all the depends from the manifest of modules using this module

@moylop260
Don't worry, there is already a procedure for all changes in OpenUpgrade.

luisg123v · 2023-12-01T18:07:40Z

Don't worry, there is already a procedure for all changes in OpenUpgrade.

Not for this:

and you will need to change all the depends from the manifest of modules using this module

😄

FernandoRomera · 2023-12-03T08:49:51Z

Don't worry, there is already a procedure for all changes in OpenUpgrade.

Not for this:

and you will need to change all the depends from the manifest of modules using this module

😄

You are right, but now is the time to do it and make the nomenclature of the modules consistent.

in the first line of the commit you indicate that you synchronize with the module partner_second_lastname

Therefore partner_contact is like this:
partner_firstname
partner_second_lastname

and in hr
hr_employee_firstname
hr_employee_second_lastname

This is my last comment for it, thanks for all the work done.

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/fa/

Currently translated at 100,0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/pt_BR/

Currently translated at 100.0% (8 of 8 strings) Translation: hr-16.0/hr-16.0-hr_employee_lastnames Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_lastnames/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_lastnames Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_lastnames/

Rename file of hooks to follow guidelines.

andreagidaltig · 2023-12-21T18:08:01Z

Hi @luisg123v could you review this, please? I just added the commit to rename the module.

luisg123v · 2023-12-21T21:37:07Z

/ocabot migration hr_employee_lastnames

OCA-git-bot · 2023-12-21T21:37:49Z

Sorry @luisg123v you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

luisg123v · 2023-12-21T21:52:34Z

hr_employee_second_lastname/__init__.py

Commit message:

AFAIK tag for module renaming is [MOV]

Commit message doesn't mention where the module is being renamed from. It should include both from and to, e.g.:
Module is renamed from hr_employee_lastnames → hr_employee_second_lastname inorder to be consistent with...

luisg123v · 2023-12-21T21:56:40Z

hr_employee_second_lastname/__manifest__.py

@@ -1,7 +1,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).


Commit message:

sicronize -> synchronize. Besides, this would only go in PR description because it's not done on this commit anymore

"Rename hooks file to follow guidelines.": not done on this commit anymore. This was done on v16, so not part of the migration anymore (hence should be removed also from PR's description).

luisg123v · 2023-12-21T21:58:24Z

hr_employee_second_lastname/tests/test_hr_employee_lastnames.py



 class TestEmployeeLastnames(TransactionCase):
    def setUp(self):
-        super(TestEmployeeLastnames, self).setUp()
+        super().setUp()


Document in commit description

luisg123v · 2023-12-21T22:00:48Z

hr_employee_second_lastname/hooks.py

+    # (firstname, lastname and lastname2).
+    #
+    # For example:
+    #  After install hr_employee_fisrtname and before install hr_employee_lastnames:


Missing renaming module here

luisg123v · 2023-12-21T22:01:13Z

hr_employee_second_lastname/hooks.py

+    #     firstname = 'John'
+    #     lastname = 'Peterson'
+    #     lastname2 = 'Clinton'
+    env.cr.execute("UPDATE hr_employee SET firstname = NULL, lastname = NULL")


Missing renaming module here

luisg123v · 2023-12-21T22:03:46Z

hr_employee_second_lastname/tests/__init__.py

@@ -0,0 +1,3 @@
+# Copyright (C) 2014 Savoir-faire Linux. All Rights Reserved.
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+from . import test_hr_employee_lastnames


And here.

Please fix all similar cases.

andreagidaltig · 2023-12-22T21:40:10Z

Hi @luisg123v changes applied, could you review again, please?

luisg123v · 2023-12-23T20:39:06Z

hr_employee_second_lastname/tests/test_hr_employee_second_lastname.py

+from odoo.tools import submap
+
+
+class TestEmployeeLastnames(TransactionCase):


You forgot to update lastnames -> second lastname here.

I just updated this, could you review again, please?

Module is renamed from hr_employee_lastnames → hr_employee_second_lastname in order to be consistent with partner_second_lastname module.

- Fix some new lints. - Update incoming parameters of post_init_hook method since `cr, registry` were replaced by `env` in [1]. - Deprecate the use of _onchange_spec method and use the method new method _get_fields_spec to return the fields specification from a view description since it was introduced in [2]. [1] odoo/odoo@b4a7996 [2] odoo/odoo@f5e6494

luisg123v

LGTM 👍

@moylop260 could you review/merge, please?

moylop260 · 2023-12-26T16:52:07Z

/ocabot merge nobump

OCA-git-bot · 2023-12-26T16:52:29Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1315-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-26T16:56:17Z

Congratulations, your PR was merged at 7bfa760. Thanks a lot for contributing to OCA. ❤️

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch 2 times, most recently from 4b4c2d0 to 29a2ce1 Compare November 16, 2023 22:23

FrancoMaxime suggested changes Nov 27, 2023

View reviewed changes

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch from 29a2ce1 to 63591ac Compare November 27, 2023 18:08

luisg123v suggested changes Nov 27, 2023

View reviewed changes

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch 2 times, most recently from 3f311c4 to 2cf094e Compare November 29, 2023 21:19

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch 2 times, most recently from 917966f to 2e1db70 Compare December 4, 2023 02:34

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch from 2e1db70 to 3c58fef Compare December 21, 2023 17:52

oca-ci and others added 11 commits December 21, 2023 18:03

[UPD] Update hr_employee_firstname.pot

c92d000

[BOT] post-merge updates

3b91429

[10.0][ADD] hr_holidays_settings

1493f80

[FIX] add company_id in view

0628552

[FIX][hr_holidays_settings] Make 'Leave Types' view accessible (OCA#408)

f8696c1

OCA Transbot updated translations from Transifex

10a070b

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[MIG] hr_holidays_settings: Migration to 11.0

2b784dc

OCA Transbot updated translations from Transifex

91068bc

[UPD] Update hr_holidays_settings.pot

1308a32

Translated using Weblate (Persian)

122cce7

Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/fa/

Translated using Weblate (Portuguese (Brazil))

b88ec50

Currently translated at 100,0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/pt_BR/

mymage and others added 6 commits December 21, 2023 18:03

Added translation using Weblate (Italian)

3b0854a

Translated using Weblate (Spanish)

189c079

Currently translated at 100.0% (8 of 8 strings) Translation: hr-16.0/hr-16.0-hr_employee_lastnames Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_lastnames/es/

[UPD] README.rst

b446838

Update translation files

76489f7

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_lastnames Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_lastnames/

[IMP] hr_employee_lastnames: rename hooks file

3afb89d

Rename file of hooks to follow guidelines.

[BOT] post-merge updates

6c94390

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch from 3c58fef to f466431 Compare December 21, 2023 18:03

luisg123v suggested changes Dec 21, 2023

View reviewed changes

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch 3 times, most recently from 2c79f9d to aacd8a6 Compare December 22, 2023 21:36

andreagidaltig requested a review from luisg123v December 22, 2023 21:42

luisg123v reviewed Dec 23, 2023

View reviewed changes

andreagidaltig added 3 commits December 26, 2023 16:03

[MOV] hr_employee_second_lastname: rename module

f862d13

Module is renamed from hr_employee_lastnames → hr_employee_second_lastname in order to be consistent with partner_second_lastname module.

[IMP] hr_employee_second_lastname: pre-commit stuff

1af4be5

andreagidaltig force-pushed the 17.0-mig-hr-employee-lastnames branch from aacd8a6 to 4fb14e7 Compare December 26, 2023 16:07

andreagidaltig requested a review from luisg123v December 26, 2023 16:11

luisg123v approved these changes Dec 26, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 26, 2023

OCA-git-bot merged commit e1415b8 into OCA:17.0 Dec 26, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] hr_employee_lastnames: Migration to 17.0 #1315

[17.0][MIG] hr_employee_lastnames: Migration to 17.0 #1315

andreagidaltig commented Nov 16, 2023 •

edited

Loading

andreagidaltig commented Nov 16, 2023

FernandoRomera commented Nov 20, 2023

FrancoMaxime Nov 27, 2023

luisg123v Nov 27, 2023

FrancoMaxime Jan 8, 2024

luisg123v commented Nov 27, 2023

luisg123v Nov 27, 2023

FernandoRomera commented Dec 1, 2023 •

edited

Loading

luisg123v commented Dec 1, 2023

moylop260 commented Dec 1, 2023

FernandoRomera commented Dec 1, 2023

luisg123v commented Dec 1, 2023

FernandoRomera commented Dec 3, 2023

andreagidaltig commented Dec 21, 2023

luisg123v commented Dec 21, 2023

OCA-git-bot commented Dec 21, 2023

luisg123v Dec 21, 2023

luisg123v Dec 21, 2023

luisg123v Dec 21, 2023

luisg123v Dec 21, 2023

luisg123v Dec 21, 2023

luisg123v Dec 21, 2023

andreagidaltig commented Dec 22, 2023

luisg123v Dec 23, 2023

andreagidaltig Dec 26, 2023

luisg123v left a comment

moylop260 commented Dec 26, 2023

OCA-git-bot commented Dec 26, 2023

OCA-git-bot commented Dec 26, 2023

		@@ -0,0 +1,2 @@
		from . import models
		from .hooks import post_init_hook

		@@ -1,7 +1,7 @@
		# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

		from odoo.tools import submap


		class TestEmployeeLastnames(TransactionCase):

[17.0][MIG] hr_employee_lastnames: Migration to 17.0 #1315

[17.0][MIG] hr_employee_lastnames: Migration to 17.0 #1315

Conversation

andreagidaltig commented Nov 16, 2023 • edited Loading

andreagidaltig commented Nov 16, 2023

FernandoRomera commented Nov 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisg123v commented Nov 27, 2023

Choose a reason for hiding this comment

FernandoRomera commented Dec 1, 2023 • edited Loading

luisg123v commented Dec 1, 2023

moylop260 commented Dec 1, 2023

FernandoRomera commented Dec 1, 2023

luisg123v commented Dec 1, 2023

FernandoRomera commented Dec 3, 2023

andreagidaltig commented Dec 21, 2023

luisg123v commented Dec 21, 2023

OCA-git-bot commented Dec 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreagidaltig commented Dec 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisg123v left a comment

Choose a reason for hiding this comment

moylop260 commented Dec 26, 2023

OCA-git-bot commented Dec 26, 2023

OCA-git-bot commented Dec 26, 2023

andreagidaltig commented Nov 16, 2023 •

edited

Loading

FernandoRomera commented Dec 1, 2023 •

edited

Loading