[18.0][MIG] hr_employee_second_lastname: Migration to 18.0 #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edy1192
force-pushed
the
18.0-mig-hr-employee-second-lastname
branch
from
047a002 to
7f20b88
Compare
Module is renamed from hr_employee_lastnames → hr_employee_second_lastname in order to be consistent with partner_second_lastname module.
- Fix some new lints. - Update incoming parameters of post_init_hook method since `cr, registry` were replaced by `env` in [1]. - Deprecate the use of _onchange_spec method and use the method new method _get_fields_spec to return the fields specification from a view description since it was introduced in [2]. [1] odoo/odoo@b4a7996 [2] odoo/odoo@f5e6494
edy1192
force-pushed
the
18.0-mig-hr-employee-second-lastname
branch
from
7f20b88 to
833abf0
Compare
|
Hi @luisg123v @luistorresm @andreagidaltig could you check this, please? Regards. |
LGTM 👍 |
|
Hi @luisg123v could you check this, please? |
luisg123v
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
LGTM 👍
@moylop260 could you review/merge, please?
Remember to run the command to mark this as a migration PR.
|
/ocabot migration hr_employee_second_lastname |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at e316bcc. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.