TypeError: unsupported operand type(s) for 'NoneType' and 'float' (using Queries)

[Mraimou]

Hello,
I'm using kpis in my report based on queries:
kpi1.expression: q1.field1
kpi2.expression: q2.field2
kpi3.expression: q1.field1 + q2.field2
I'm getting TypeError: unsupported operand type(s) for 'NoneType' and 'float' when a query returns None.
I noticed that in case of accounting expressions None is replaced by AccountingNone:
replaced_expr = aep.replace_expr(expression) => '(AccountingNone)'
val = mis_safe_eval(replaced_expr, locals_dict) => AccountingNone

but in case of queries:
replaced_expr==expression => q1.field1 + q2.field2
val = mis_safe_eval(replaced_expr, locals_dict) => #ERR

[sbidoul]

This should have been fixed in version 3.3.0. Which version are you using?

[Mraimou]

I'm using 3.3.0
do you mean this fix?
I noticed that's related to conversion between AccountingNone and other types & vice versa.
but in the error i'm getting, the problem is caused by 'NoneType' and 'float'

[sbidoul]

@Mraimou ah yes, I misread. So yes, this looks like a small bug.

You can probably work around it by writing (q1.field1 if q1.field1 is not None else AccountingNone) + q2.field2. Or (q1.field1 or 0.0) + q2.field2 if you don't care about nulls.

[Mraimou]

Yes, sounds good!
Thank you @sbidoul

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.