Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W7936 is triggered when a package name is different from the import #75

Open
bartvanbossche-dynapps opened this issue Jan 31, 2023 · 1 comment

Comments

@bartvanbossche-dynapps
Copy link

In one of our modules we're using the python library 'smbprotocol'. This is a wrapper for smbclient functions.
In our manifest we have the following external dependencies:
"external_dependencies": {"python": ["smbprotocol"]},
However, in the python files we import smblient:
import smbclient
When we run pre-commit we get the following warning:
xx_base_integration/models/integration.py:1: [W7936(missing-manifest-dependency), ] Missing external dependency "smbclient" from manifest. More info: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#external-dependencies

@sbidoul
Copy link
Member

sbidoul commented Apr 5, 2023

IIRC this is just a warning and this check has been disabled in latest version of the repo template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants