Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] Migrate payroll_account #84

Merged
merged 23 commits into from
Nov 11, 2022

Conversation

mtelahun
Copy link
Contributor

@mtelahun mtelahun commented Oct 14, 2022

Requires #81 to be merged first

Fixes: #19
cc: #78

@nimarosa
Copy link
Contributor

/ocabot migration payroll_account

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 14, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 14, 2022
6 tasks
@mtelahun
Copy link
Contributor Author

/ocabot migration payroll_account

This PR is waiting on #81 to be merged

@nimarosa
Copy link
Contributor

@mtelahun i think recently they were a few changes in payroll_account so please when payroll migration is merged rebase this to include last version of module.

@mtelahun
Copy link
Contributor Author

mtelahun commented Nov 11, 2022 via email

Saran440 and others added 23 commits November 11, 2022 11:46
Currently translated at 100.0% (24 of 24 strings)

Translation: payroll-14.0/payroll-14.0-payroll_account
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/ca/
Currently translated at 16.6% (4 of 24 strings)

Translation: payroll-14.0/payroll-14.0-payroll_account
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings)

Translation: payroll-14.0/payroll-14.0-payroll_account
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings)

Translation: payroll-14.0/payroll-14.0-payroll_account
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es/
…or the payslip

Until now this module tried to confirm an empty account move. This caused
the account module to throw an exception. This causes problems in
other modules that may not know about payroll_account. For example
in other modules' tests.
Currently translated at 100.0% (24 of 24 strings)

Translation: payroll-14.0/payroll-14.0-payroll_account
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings)

Translation: payroll-14.0/payroll-14.0-payroll_account
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es/
…cumentation

[14.0] [IMP] payroll: improve salary rules views and documentation

[14.0] [IMP] payroll: improve salary rules  and categories views

[14.0] [IMP] payroll: improve salary rules views and documentation

[14.0] [IMP] payroll: improve salary rules views and documentation

[IMP] payroll: fix repeated words

[14.0] [IMP] payroll: fix typos
[14.0] [IMP] payroll: change manifest category

[14.0] [IMP] payroll: add migration for new payslip and payslips objects

[14.0] [IMP] payroll: add migration for new payslip and payslips objects

[14.0] [IMP] payroll: add migration for new payslip and payslips objects
@mtelahun mtelahun force-pushed the 15.0-mig-payroll_account branch from 9bf6341 to 91c8c41 Compare November 11, 2022 08:51
@mtelahun
Copy link
Contributor Author

@nimarosa @appstogrow payroll_account is also ready with latest changes. I did a simple functional test.

@ghost
Copy link

ghost commented Nov 11, 2022

I am travelling this weekend. I have not reviewed or tested, but I trust it is good, so for my sake you can merge.

@nimarosa
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-84-by-nimarosa-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 11, 2022
Signed-off-by nimarosa
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-84-by-nimarosa-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 223171f into OCA:15.0 Nov 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 87311a5. Thanks a lot for contributing to OCA. ❤️

@mtelahun mtelahun deleted the 15.0-mig-payroll_account branch November 12, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants