Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deskew: respect PAGE coordinate consistency principle #47

Open
bertsky opened this issue Apr 3, 2020 · 2 comments
Open

deskew: respect PAGE coordinate consistency principle #47

bertsky opened this issue Apr 3, 2020 · 2 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Apr 3, 2020

In https://github.com/kba/ocrd_anybaseocr/blob/c65f67e3afc740d70acca18dc3d2c2b778d54d18/ocrd_anybaseocr/cli/ocrd_anybaseocr_deskew.py#L159, the rotation is applied without also enlarging the image respectively. This not only looses information (in the corners), but also violates our consistency principle. Subsequent processors will inevitably plunge into coordinates with some offset.

@kba
Copy link
Member

kba commented Jun 8, 2020

@EEngl52 in #51:

when deskewing with ocrd-anybaseocr-deskew the coordinates from the Alternative Image produced in this process seem to be used for all further steps. In the end, the coordinates of all regions, lines, words etc. are wrong, even though the text is fully detected.
kit3.zip

@bertsky
Copy link
Contributor Author

bertsky commented May 2, 2022

I suggest we simply drop the ocrd-anybaseocr-deskew processor. It is incorrect and offers no advantage over the earlier and better ocrd-cis-ocropy-deskew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants