Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop creating directories in the input fileGrp #60

Closed
bertsky opened this issue Jun 19, 2020 · 4 comments
Closed

stop creating directories in the input fileGrp #60

bertsky opened this issue Jun 19, 2020 · 4 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Jun 19, 2020

Probably a left-over of some failed attempt at temporary file I/O…

os.mkdir(self.input_file_grp+"/test_A/")

os.rmdir(self.input_file_grp+"/test_A/") #FIXME: better way of deleting a temp_dir?

…these should be removed.

@bertsky
Copy link
Contributor Author

bertsky commented Jun 19, 2020

Can also cause failures:

FileExistsError: [Errno 17] File exists: 'OCR-D-IMG-DEN-BINPAGE-sauvola-DENOISE-ocropy/test_A/'

@kba
Copy link
Member

kba commented Aug 22, 2020

 os.mkdir(self.input_file_grp+"/test_A/") 

This is necessary because pix2pixHD expects this directory, named exactly like that, in that place. The data flow in pix2pixHD's plumbing is so convoluted that it's hard to say without trial&error how to fix this. I have no CUDA hardware, so I cannot test the dewarping unfortunately.

@bertsky
Copy link
Contributor Author

bertsky commented Aug 22, 2020

This is necessary because pix2pixHD expects this directory, named exactly like that, in that place. The data flow in pix2pixHD's plumbing is so convoluted that it's hard to say without trial&error how to fix this.

Understood. Than we should document that, and fix the problem of repeated mkdir (which is now more realistic due to --overwrite).

I have no CUDA hardware, so I cannot test the dewarping unfortunately.

Too bad!

@kba
Copy link
Member

kba commented Mar 20, 2022

fixed by #89

@kba kba closed this as completed Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants