-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Furo theme #1220
Switch to Furo theme #1220
Conversation
I dislike rtd theme we use for our sphinx documentation. This PR replaces it by Furo theme. This theme is more responsive.
Uhm, strange. It seems that building failed but the dependencies are correctly installed and it works on my computer. I will investigate. |
This is a visual documentation changes that needs visuals to be reviewed. Can you build the theme on your own GitHub Pages account and provide a link so that we can see what it looks like? This should also allow to test the bit of JS code we have for multi-version support that may or may not need to be adapted to this new theme. I would normally be a bit uncomfortable changing the documentation theme this way in a rush before the release, and think this should have been discussed more (I don't really like the ReadTheDoc theme we are using either, but I don't know that Furo is the one we want to use to replace it) beforehand. That said — we are already making changes to the structure of the documentation (splitting languages and models etc.), so it is better to bundle it with the visual change if possible, to make it a single user-visible change. |
Sure we should check. Besides your menu to switch between versions hasn't been pushed on |
The result: https://halbaroth.github.io/alt-ergo/next/ The menu is broken, I will fix it. |
I think there is no risk to change the theme before the release. This documentation is not a part of the opam package. If we ran into a problem just after the release, we can easily rollback to the previous theme. |
That's intentional because it would require back-porting the changes to v2.5.4 (but actually I can add the menu manually). (Note that |
After a quick look around — that looks better than ReadTheDocs but there seems to be some issues/glitches. The sub-section headers are not rendered properly in the side bar These should be sub-headers of the AB why3 plugin section otherwise it is confusing, see current Tables look very ugly: Maybe we have some custom CSS interfering? They look OK on the Furo demo I have also noticed that we have some rendering glitches due to not setting properly the language on code blocks, but that is unrelated. I will do a pass to fix these. |
Please do not. I did it ;) |
The risk is in the perception by users. I hate it when projects change website looks left and right and find it disorienting, and so I'd like to minimize the changes we make to the website for released versions. |
This extension does not work well with Furo theme. We don't need it because we switch from the depracated markdown parser `recommonmark` to MyST.
The option |
docs/sphinx_docs/Plugins/index.md
Outdated
@@ -13,7 +13,9 @@ The `fm-simplex` inequality plugin comes built-in with Alt-Ergo and no further | |||
installation is required. It is distributed under the same licensing conditions | |||
as Alt-Ergo. It can be used as follows: | |||
|
|||
$ alt-ergo --inequalities-plugin fm-simplex [other-options] file.<ext> | |||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sh
is the lexer for (ba)sh scripts; console
should be used for interactive sessions.
If we are fixing language for code blocks here there are also some on the "Model generation" page that use the default |
I know but I already fix that in another PR. |
I dislike rtd theme we use for our sphinx documentation. This PR replaces it by Furo theme. This theme is more responsive.