Degraded performance upgrading from 7 to 8, workaround

[arkblad]

When we upgraded from version 7 to 8, we noticed a degraded performance in our OData controllers.
As the application grew, this became more and more problematic.

On the first call to one of our dynamic Query controllers, the application locked up for about 1-2 minutes.
It turned out that creating an EdmModel, initialized by ODataQueryParameterBinding (ODataQueryOptions) took a very long time in a large application (700+ entities). This was then done for each endpoint, which became a high unexpected cost.

Inspired by the following:
ActionDescriptorExtensions

Our solution around the problem was to force the construction of the entire EdmModel on startup, and add to the respective ActionDescriptor.

Is it wrong thought?

private const string ModelKeyPrefix = "Microsoft.AspNetCore.OData.Model+";
private static readonly object SyncLock = new object();

internal static void InitializeOdata(IActionDescriptorCollectionProvider actionDescriptorCollectionProvider, IAssemblyResolver assemblyResolver)
    {

        var routes = actionDescriptorCollectionProvider.ActionDescriptors.Items.Where(
               x => x.AttributeRouteInfo != null).ToList();

        List<Tuple<Type, ControllerActionDescriptor>> descriptors = new List<Tuple<Type, ControllerActionDescriptor>>();
        var builder = new ODataConventionModelBuilder(assemblyResolver, isQueryCompositionMode: true);
        foreach (ControllerActionDescriptor item in routes)
        {
            if (item.EndpointMetadata.Any(x => x.GetType() == typeof(ODataEndpointAttribute))) //Our own attribute to identitfy odata query endpoints
            {
                var type = item.ControllerTypeInfo.BaseType.GenericTypeArguments[0];
                EntityTypeConfiguration entityTypeConfiguration = builder.AddEntityType(type);
                if (!builder.EntitySets.Any(c => c.Name == type.Name))
                {
                    builder.AddEntitySet(type.Name, entityTypeConfiguration);
                }
                descriptors.Add(new Tuple<Type, ControllerActionDescriptor>(type, item));
            }
        }
        var model = builder.GetEdmModel(); //build once.
        foreach (var desc in descriptors)
        {
            string key = ModelKeyPrefix + desc.Item1;
            lock (SyncLock)
            {
                if (!desc.Item2.Properties.ContainsKey(key))
                {
                    desc.Item2.Properties.Add(key, model);
                }
            }
        }
    }

[xuzhg]

https://github.com/xuzhg/WebApiSample/tree/main/v8.x/GenericControllerSample for your reference if the controller is generic type.