Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean for main branch #3132

Open
xuzhg opened this issue Nov 23, 2024 · 0 comments · May be fixed by #3146
Open

Code clean for main branch #3132

xuzhg opened this issue Nov 23, 2024 · 0 comments · May be fixed by #3146
Assignees

Comments

@xuzhg
Copy link
Member

xuzhg commented Nov 23, 2024

Short summary (3-5 sentences) describing the issue.

Couple things to track on

1) We have lot of 'Backup' files created, for example
https://github.com/OData/odata.net/blob/main/test/FunctionalTests/Microsoft.OData.Core.Tests/Microsoft%20-%20Backup.OData.Core.Tests.csproj

https://github.com/OData/odata.net/blob/main/test/FunctionalTests/Tests/DataOData/Common/OData/Microsoft%20-%20Backup.Test.Taupo.OData.csproj

.... Fixed in #3142

They are added when creating the first version of ODL 8. I don't think we still need to keep them.

2) There's a lot of non active codes and setting. for example: Fixed in #3142

https://github.com/OData/odata.net/blob/main/src/Microsoft.OData.Core/ShippingAssemblyAttributes.cs#L24 (We don't have .NetCore version again)

or
https://github.com/OData/odata.net/blob/main/test/FunctionalTests/Microsoft.OData.Core.Tests/Microsoft.OData.Core.Tests.csproj#L74
(We don't target on .net48 again)

  1. OData 8.x still use 'tt' and 'txt' file to generate the error message.
    For example: https://github.com/OData/odata.net/blob/main/src/Microsoft.OData.Edm/Microsoft.OData.Edm.txt

We should use the Resource (.resx) to replace them.

  1. There's no public API test running. Since we have move to use the 'Microsoft.CodeAnalysis.PublicApiAnalyzers', maybe we don't need the old public api test???

5. For the 4 product libraries, 'Microsoft.CodeAnalysis.NetAnalyzers' is required to run 'FxCop' for code analysis. Fixed in #3142

6) Fix the nuget package vulnerable issues. Fixed in 29a1676

Reproduce steps

The simplest set of steps to reproduce the issue. If possible, reference a commit that demonstrates the issue.

Expected result

What would happen if there wasn't a bug.

Actual result

What is actually happening.

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.

xuzhg added a commit that referenced this issue Dec 9, 2024
1) Remove the old tt files
2) Convert the error messages from txt files to resx files
3) Add the Error class for helpers
4) Change the codes to use the resource error message
xuzhg added a commit that referenced this issue Dec 10, 2024
1) Remove the old tt files
2) Convert the error messages from txt files to resx files
3) Add the Error class for helpers
4) Change the codes to use the resource error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants