Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to NOT_APPLICABLE docs in Shiny app UI. #550

Open
MelaniePhilofsky opened this issue May 25, 2024 · 3 comments
Open

Link to NOT_APPLICABLE docs in Shiny app UI. #550

MelaniePhilofsky opened this issue May 25, 2024 · 3 comments
Assignees

Comments

@MelaniePhilofsky
Copy link

While reviewing our most recent, DQD v2.6, results. I came across some new checks with wording that might be misinterpreted by users reviewing the checks.

The checks have DQD STATUS = "NOT APPLICABLE".

The error message states the data are "missing". This is a little nit picky, but missing Implies the data should be there. However, these fields are not required. And we have purposely not populated the field (i.e. Payer_Plan_Period.sponsor_concept_id) since we do not have these data. I would suggest "missing" be replace by "not present".

@katy-sadowski
Copy link
Collaborator

Hi @MelaniePhilofsky ! Could you please clarify which error message you're referring to?

The NOT_APPLICABLE status is designed for the scenario you're describing - these are checks that can be disregarded because a column or table is not populated. Docs have more info: https://ohdsi.github.io/DataQualityDashboard/articles/CheckStatusDefinitions.html#not-applicable

@MelaniePhilofsky
Copy link
Author

MelaniePhilofsky commented May 25, 2024 via email

@katy-sadowski
Copy link
Collaborator

That's a good idea, Melanie. I'll keep this issue open and pull it into work for the upcoming release which is focused on documentation.

@katy-sadowski katy-sadowski changed the title Wording of new checks Link to NOT_APPLICABLE docs in Shiny app UI. May 25, 2024
@katy-sadowski katy-sadowski self-assigned this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TODO
Development

No branches or pull requests

2 participants