-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview and Checkresults counts are not matching when missing specific checkNames #565
Comments
Thanks @Bharathi1991 for moving your report over here! One thing to confirm - when you do include those 3 checks, you do not experience this issue with the pass/fail counts in the summary table? Also, are you seeing any issue with check statuses in the full list of check results, or does this just impact the summary table? |
Hi @katy-sadowski , Can you please clarify if you referring to the table that gets created in results schema dqdashboard_results by summary table? The And when we include all these 3 checks in Hope I understood your question correctly. Can you please let me know if my answer is unclear. |
@Bharathi1991 any update here? |
I am using R 4.3.1 and DQD 2.6.1. I am noticing a difference between checkResults and Overview object in the results produced by
executeDQChecks
method in DQD Dashboard when certain checkNames are omitted from the list. These checkNames are defined here in calculateNotApplicableStatus.R. In the absence of any one of these 3 checkNames, the code does not update the default value for passed column which is zero (initialized here and updated within calculateNotApplicableStatus.R here. So, if we miss to add those 3 checkNames, this results in this mismatch. Screenshots showing this behavior can be seen below,resultsViewer
Showing 0 for passed column
Overview
results$overview
object showing a non-zerocountPassed
valueDQD Dashboard
Results from inaccurate checkResults object
Relevant OHDSI Forum post - https://forums.ohdsi.org/t/dqd-results-mismatch-between-overview-and-checkresults-when-missing-specific-checknames/22337
Can anyone help me understand why we require these 3 speciifc checks to update the column. Just curious to know if these 3 checks are of some significance among the rest. If not, can we please update the code so that the overview and checkResults objects are always in alignment with each other.
The text was updated successfully, but these errors were encountered: