Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pull() in CodeToRun exclude checks workflow #568

Open
katy-sadowski opened this issue Oct 7, 2024 · 1 comment
Open

Missing pull() in CodeToRun exclude checks workflow #568

katy-sadowski opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@katy-sadowski
Copy link
Collaborator

katy-sadowski commented Oct 7, 2024

# select(checkName)

Also, we should call library(dplyr) at the top.

Also, this shouldn't have cdmSourceName in it:

ParallelLogger::launchLogViewer(logFileName = file.path(outputFolder, cdmSourceName,

@samhillman
Copy link
Collaborator

Pull request available to #574. Update the checksToExclude by changing the select() to a pull() to make sure we return the vector only rather than a column. Add explicit namespacing and call the library(dplyr) at the top of the commented code. Update the inspect logs code to correct the file.path() argument to include the cdmSourceName only in the .txt file name.

katy-sadowski added a commit that referenced this issue Oct 24, 2024
Fix missing pull() and wrong launchLogViewer() file.path() argument fix #568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Merged into develop branch
Development

No branches or pull requests

2 participants