Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check: field_fkdomain_episode_episode_object_concept_id doesn't align with OMOP CDM 5.4 Specification #578

Open
teenwyman opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@teenwyman
Copy link

teenwyman commented Nov 25, 2024

Referring to OMOP CDM 5.4 Specification:
image

• ‘Procedure’ or ‘Regimen’ concepts are applicable for Treatment Regimen Episodes.
• ‘Condition’ concepts are applicable for Disease Episodes.

However, the DQD field_fkdomain_episode_episode_object_concept_id check does not align with it.
(The number and percent of records that have a value in the EPISODE_OBJECT_CONCEPT_ID field in the EPISODE table that do not conform to the PROCEDURE OR REGIMEN domain)

Also, there is typo misstake in the SQL: co.domain_id NOT IN (‘Procedure OR Regimen’)

@katy-sadowski katy-sadowski self-assigned this Nov 26, 2024
@katy-sadowski katy-sadowski added the bug Something isn't working label Nov 26, 2024
@katy-sadowski
Copy link
Collaborator

Sorry about this! This is a bug that was fixed a while back but somehow reappeared. This check should be disabled for this field because DQD currently does not support checking of multiple domains in this way. I will open a PR to disable this check by default.

In the meantime, you can disable the check in your local threshold file to silence the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants