Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLP Results Model using Timestamp data type for execution_date_time #407

Closed
anthonysena opened this issue Aug 11, 2023 · 0 comments · Fixed by #408
Closed

PLP Results Model using Timestamp data type for execution_date_time #407

anthonysena opened this issue Aug 11, 2023 · 0 comments · Fixed by #408

Comments

@anthonysena
Copy link
Contributor

The PLP Results Model currently defined the column execution_date_time as a DATETIME2 which is generally translated to a TIMESTAMP data type for most RDBMs (I'm mainly focused on PostgreSQL for the purposes of this issue). For reference, this column is declared for 3 different tables here, here, and here.

I'm currently facing a situation when inserting data into the PLP results data model whereby the insert fails with the error described here: OHDSI/DatabaseConnector#240. I believe this is due to the fact that the execution_date_time captured in the output .csv files only has the date and not the time and so the conversion to a timestamp causes an overflow error.

I'd propose changing this column to a VARCHAR(100) instead to avoid this upload error and perhaps a patch should be put together to add the time portion of the datetime captured for the execution_date_time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants