[Bug] Custom Route definition now needed to include PUBLIC_URL

[salimkanoun]

Describe the Bug

When defining a customization moodle to register a custom root, now it requires to include the PUBLIC_URL in the root,

i'm using "/viewer-ohif/" in PUBLIC_URL on building

Previously I was OK with :

      {
        name: 'loginRoute',
        value: {
          id: 'customRoutes',
          routes: [
            {
              path: `/login`,
              children: () => RootGaelO(),
              private: true,
            },
            
          ],
        },
      },

and now I need to add the /viewer-ohif/ in the root definition

      {
        name: 'loginRoute',
        value: {
          id: 'customRoutes',
          routes: [
            {
              path: `/viewer-ohif/login`,
              children: () => RootGaelO(),
              private: true,
            },
            
          ],
        },
      },

That't problematic because the root defintion is now dependant on the build context.

Steps to Reproduce

1. Define a custom route in customization module without the public url in it
2. build with a public url
3. try to access the root

The current behavior

Non accessible route

The expected behavior

Route definition should be independant from the build setting to be able to be used in different context

OS

Linux

Node version

20

Browser

Chrome latest

[salimkanoun]

OK I found the solution by injecting window.PUBLIC_URL

  {
        name: 'loginRoute',
        value: {
          id: 'customRoutes',
          routes: [
            {
              path: `${window.PUBLIC_URL}login`,
              children: () => RootGaelO(),
              private: true,
            },
            
          ],
        },
      },

[salimkanoun]

reopen to discuss it tomorow (probably need to document it or add public URL while registering route)