From 53d6bd76103eaeccc9ea48d33aed479ee10e200a Mon Sep 17 00:00:00 2001 From: Alireza Date: Mon, 25 Sep 2023 23:45:28 -0400 Subject: [PATCH 1/3] chore(build): try to publish to npm again --- modes/segmentation/package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modes/segmentation/package.json b/modes/segmentation/package.json index 566dbb26eda..648a73bf350 100644 --- a/modes/segmentation/package.json +++ b/modes/segmentation/package.json @@ -14,6 +14,9 @@ "keywords": [ "ohif-mode" ], + "publishConfig": { + "access": "public" + }, "module": "src/index.tsx", "engines": { "node": ">=14", From c1fafa17ac04dc074a508951fff5cfe138ed4ef4 Mon Sep 17 00:00:00 2001 From: Alireza Date: Tue, 26 Sep 2023 07:33:53 -0400 Subject: [PATCH 2/3] fix e2e --- .../OHIFContextMenuCustomization.spec.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/platform/app/cypress/integration/measurement-tracking/OHIFContextMenuCustomization.spec.js b/platform/app/cypress/integration/measurement-tracking/OHIFContextMenuCustomization.spec.js index f4c044d08f2..7e6806413f3 100644 --- a/platform/app/cypress/integration/measurement-tracking/OHIFContextMenuCustomization.spec.js +++ b/platform/app/cypress/integration/measurement-tracking/OHIFContextMenuCustomization.spec.js @@ -12,7 +12,7 @@ describe('OHIF Context Menu', function () { // Add length measurement cy.addLengthMeasurement(); cy.get('[data-cy="prompt-begin-tracking-yes-btn"]').as('yesBtn').click(); - cy.get('[data-cy="measurement-item"]').click(); + cy.get('[data-cy="measurement-item"]').as('measurementItem').click(); const [x1, y1] = [150, 100]; cy.get('@viewport') @@ -24,13 +24,12 @@ describe('OHIF Context Menu', function () { }); // Contextmenu is visible - cy.get('[data-cy="context-menu"]').should('be.visible'); - + cy.get('[data-cy="context-menu"]').as('contextMenu').should('be.visible'); // Click "Finding" subMenu - cy.get('[data-cy="context-menu-item"]').contains('Finding').click(); + cy.get('[data-cy="context-menu-item"]').as('item').contains('Finding').click(); // Click "Finding" subMenu - cy.get('[data-cy="context-menu-item"]').contains('Aortic insufficiency').click(); - cy.get('[data-cy="measurement-item"]').contains('Aortic insufficiency'); + cy.get('[data-cy="context-menu-item"]').as('item').contains('Aortic insufficiency').click(); + cy.get('[data-cy="measurement-item"]').as('measure-item').contains('Aortic insufficiency'); }); }); From 73e1947104d1179b37204d0793c7305c5a8a4b6e Mon Sep 17 00:00:00 2001 From: Alireza Date: Tue, 26 Sep 2023 08:33:16 -0400 Subject: [PATCH 3/3] fix e2e 2 --- .../measurement-tracking/OHIFMeasurementPanel.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/app/cypress/integration/measurement-tracking/OHIFMeasurementPanel.spec.js b/platform/app/cypress/integration/measurement-tracking/OHIFMeasurementPanel.spec.js index 1cfb1cede4b..514d66c7fc2 100644 --- a/platform/app/cypress/integration/measurement-tracking/OHIFMeasurementPanel.spec.js +++ b/platform/app/cypress/integration/measurement-tracking/OHIFMeasurementPanel.spec.js @@ -42,7 +42,7 @@ describe('OHIF Measurement Panel', function () { it('checks if image would jump when clicked on a measurement item', function () { // Add length measurement - cy.addLengthMeasurement(); + cy.addLengthMeasurement().wait(250); cy.get('[data-cy="prompt-begin-tracking-yes-btn"]').as('yesBtn').click(); cy.scrollToIndex(13);