Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image registry failing for non-amd64 architectures. #249

Open
preston opened this issue Jan 18, 2025 · 6 comments
Open

Image registry failing for non-amd64 architectures. #249

preston opened this issue Jan 18, 2025 · 6 comments
Assignees

Comments

@preston
Copy link

preston commented Jan 18, 2025

It looks like the published Docker images may be for x64 CPU architectures only. Could the build process please be updated with multi-arch support including linux/arm64? It shouldn't require any code changes and immediately enable macOS and ARM-class cloud servers to run COACH. :)

Thanks and let me know if you have any questions! I'm making this request on behalf of the Veterans Health Administration, Knowledge Based Systems. If you would like to do this even more broadly via HL7 FHIR Foundry I may be able to help there as well.

@mattStorer mattStorer self-assigned this Jan 18, 2025
@mattStorer
Copy link
Collaborator

thanks @preston, I'll take a look at this and see what's up. will keep you posted.

@preston
Copy link
Author

preston commented Jan 18, 2025

Thanks @mattStorer . FYI I'm also (still) the CTO for Logica Health. We shut down the public sandbox systems a few months ago but were able to coordinate with Meld migration and are very familiar with it.

@preston
Copy link
Author

preston commented Feb 5, 2025

Any updates? I'm needing to evaluate coach for government purposes on macOS machines ("linux/arm64" platform architecture), and the linux/x64 build won't pull on arm64 for some reason. Let me know if I can help!

@mattStorer
Copy link
Collaborator

@preston hey sorry no updates as of right now, slammed with other priorities.

If you have a specific change you would like to see made in a specific file, please communicate that change and I can make it on a feature branch for you to test.

thanks -

Matt

@preston
Copy link
Author

preston commented Feb 5, 2025

@mattStorer I'm sure this isn't 100%, but it should fix the main issue of the application build not actually happening in the image build. I've redone the Dockefile to use a multi-stage image build, first running maven to build the .jar, and then the second runtime stage by copying in the .jar created in the first stage. I tested this using multiarchitecture 'docker buildx build --platform ...' builds and it does work, but I might not have copied the additional project files into the runtime stage correctly.

master...preston:coach:multiplatform-builds

Using this new multi-platform style, I can then swap it into the existing docker-compose.override.yml file and see it start up, though the app is throwing some sort of MySQL connection error that I think has to do with application.properties being missing, as that file doesn't exist in the branch :)

Let me know!

@mattStorer mattStorer added this to the 1.16.0 milestone Feb 6, 2025
@mattStorer
Copy link
Collaborator

@preston if you would like to test, checkout feature/issue249 which incorporates your change, and see how that works. thanks!

@mattStorer mattStorer removed this from the 1.16.0 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants