fips: work on fips enforced systems - v1 #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To work on machines with FIPS enfored, md5 can't be used for security, and Python enforces this by default, but can be used with an extra function argument. Re-use md5_hexdigest as it wasn't be used so we can determine if this function argument is available, as its only available on Python 3.9 and newer. Bug: #4479
|
I tested on an AlmaLinux 9 system with a kernel command line of |
inashivb
approved these changes
Jul 10, 2024
|
Merged. |
|
@jasonish can this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: set usedforsecurity=False for md5 operations
To work on machines with FIPS enfored, md5 can't be used for security,
and Python enforces this by default, but can be used with an extra
function argument.
Re-use md5_hexdigest as it wasn't be used so we can determine if this
function argument is available, as its only available on Python 3.9
and newer.
Bug: https://redmine.openinfosecfoundation.org/issues/4479
Plus some CI fixups.