Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide optional dependencies for opm #92

Open
MatthewFlamm opened this issue Nov 20, 2024 · 1 comment
Open

Provide optional dependencies for opm #92

MatthewFlamm opened this issue Nov 20, 2024 · 1 comment

Comments

@MatthewFlamm
Copy link

The documentation suggests optionally installing opm python package using pip install opm

For not macOS users, to install the Python OPM package, execute in the terminal pip install opm.

It would be convenient for users to install everything in one go using pip install pyopmspe11[opm] by declaring it as an optional dependency in pyproject.toml. https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements.

While nice for users, this is not directly relevant to the review in openjournals/joss-reviews#7357.

@daavid00
Copy link
Collaborator

daavid00 commented Dec 4, 2024

Thanks @MatthewFlamm for the suggestion, this has been added in #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants