Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwp_time_factor will always be 6 #88

Open
simonrp84 opened this issue Jun 26, 2023 · 0 comments
Open

nwp_time_factor will always be 6 #88

simonrp84 opened this issue Jun 26, 2023 · 0 comments
Assignees
Labels

Comments

@simonrp84
Copy link
Collaborator

simonrp84 commented Jun 26, 2023

In commit #dd387e9, logic was added to determine if the time factor for NWP data should be 6 hours or 1 hour (in support of the hourly data available in ERA5) in orac_preproc.F90:

   ! If we're reading BADC ERA5 data, we default to one file every hour,
   ! otherwise assume it's one every six hours.
   if (nwp_flag .eq. 2) then
      preproc_opts%nwp_time_factor       = 1.
   else
      preproc_opts%nwp_time_factor       = 6.
   end if

This code is too early, and it's called before nwp_flag is read from the driver file. Therefore, nwp_time_factor will always be 6.
I can't fix it myself right now, but I suggest moving the above lines to somewhere around line number 620. At that point the driver file is read and nwp_flag will be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants