Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions as arguments #29

Open
lizgzil opened this issue Jan 21, 2020 · 0 comments
Open

versions as arguments #29

lizgzil opened this issue Jan 21, 2020 · 0 comments

Comments

@lizgzil
Copy link

lizgzil commented Jan 21, 2020

It'd be nice to have the version parameters as arguments to the PublicAPI class in orcid.py. At the moment I can't use your code since SEARCH_VERSION is hard coded in (I wanted to use SEARCH_VERSION="/v3.0").
e.g.

class PublicAPI(object):
    """Public API."""

    TYPES_WITH_PUTCODES = set(['address',
                               'education',
                               'email',
                               'employment',
                               'external-identifier',
                               'funding',
                               'keywords',
                               'other-names',
                               'peer-review',
                               'researcher-urls',
                               'work'])

    TYPES_WITH_MULTIPLE_PUTCODES = set(['works'])

    def __init__(self, institution_key, institution_secret, sandbox=False,
                 timeout=None, do_store_raw_response=False, search_version="/v2.0"):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant