Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix pylint pointless-statement (W0104) #3996

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Jul 7, 2024

Equivalent ruff rule is useless-expression (B018) from flake8-bugbear.

One file contains changes that would've been changed in #3886, but that PR has other changes.

This is part of the effort to introduce Pylint 3.x for #3921

@echoix echoix added this to the 8.5.0 milestone Jul 7, 2024
@echoix echoix requested a review from ninsbl July 7, 2024 23:18
python/grass/imaging/images2gif.py Show resolved Hide resolved
@echoix echoix merged commit cd64472 into OSGeo:main Jul 8, 2024
27 checks passed
@echoix echoix deleted the fix-pointless-statement branch July 8, 2024 15:39
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Jul 23, 2024
* temporal: Actually call dbif.close() to fix pylint pointless-statement (W0104)

* g.extension: Fix pylint pointless-statement (W0104)

* temporal: Fix pointless-statement (W0104) in temporal_granularity

* temporal: Fix pointless-statement (W0104) in c_libraries_interface.py, _read_vector_history() function

* i.atcorr: Remove useless and non-working print statements in create_iwave.py

* python(grass.imaging): Use PIL.__version__ call to fix pylint pointless-statement

* style: Ignore ruff useless-expression (B018) for a gunittest data file. Equivalent to pylint pointless-statement / W010

* style: Enable ruff useless-expression (B018) (equivalent to pylint pointless-statement / W010)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants