style: Sort package lists, configure options, and other various sortable files #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
windows
neteler
reviewed
Oct 24, 2024
|
Thanks for your efforts. We have a number of CSV files, perhaps some could be merged? Their origin is from CVS/SVN times with a different than GitHub write access model which is no longer in place:
In case of structural changes (e.g., merging selectively) also a GUI change would be needed:
contribfile = os.path.join(os.getenv("GISBASE"), "contributors_extra.csv")
contribfile = os.path.join(os.getenv("GISBASE"), "contributors.csv")
translatorsfile = os.path.join(os.getenv("GISBASE"), "translators.csv")
label=_("%s file missing") % "translators.csv",However, maybe better done in a separate PR. |
I made a separate issue for it #4599, as indeed, it is kind of a different topic than this PR. |
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Nov 11, 2024
…ble files (OSGeo#4563) * style: Sort packages in Vagrantfile * style: Sort configure flags in package.nix * style: Sort .gunittest.cfg * style: Sort Travis build files * style: Sort python optional_requirements.txt * style: Sort configure flags in GitHub workflows * style: Sort packages and configure flags for binder * style: Sort packages, configure flags, cmake flags and wget downloads in Dockerfiles * style: Sort configure flags in Vagrant script * style: Sort svn author name files with linux sort command * style: Sort contributors.csv and contributors_extra.csv * style: Sort rpm package spec * style: Sort packages and configure flags in mswindows build scripts * style: Sort macosx build script Readme * style: Sort singularity file * Apply changes from https://src.fedoraproject.org/rpms/grass/blob/rawhide/f/grass.spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from last month's #4373.
This PR sorts sortable parts of many remaining files. Build scripts, package lists, file lists, contributors lists, etc.
I made some searches on what looked like configure flags, and packages too.
About the only thing that wasn't sorted was everything in Makefiles, like directory lists or other lists in Makefiles, and the mingw64 packages in the osgeo4w.yml workflow, as the packages weren't placed in a line-delimited list yet