Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split image to registry,repository,tag #446

Closed
genofire opened this issue Feb 22, 2023 · 3 comments
Closed

Split image to registry,repository,tag #446

genofire opened this issue Feb 22, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@genofire
Copy link

genofire commented Feb 22, 2023

Is your feature request related to a problem? Please describe.
We like to use your internal cacheing of images without editing the tag/version based on the operator.

Describe the solution you'd like

type KubernetesConfig struct {
Image string `json:"image"`

Split this Image to:

  • registry
  • repository
  • tag

so an overwrite of registry has no effect on the tag.

What version of redis-operator are you using?

redis-operator version: v0.14.0

@genofire genofire added the enhancement New feature or request label Feb 22, 2023
@shubham-cmyk
Copy link
Member

@genofire This feature is already incorporated while installing redis by helm;
link here:- https://github.com/OT-CONTAINER-KIT/helm-charts

@genofire
Copy link
Author

i understand this idea - sadly the helm-charts has not the quality i like - e.g. wrong usage of helm appVersion, see for operator: OT-CONTAINER-KIT/helm-charts#71

@genofire
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants