Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey Issue: Spells Trigger Only Once When Held Down #37

Closed
Milkyy-00 opened this issue Jan 16, 2025 · 5 comments
Closed

Hotkey Issue: Spells Trigger Only Once When Held Down #37

Milkyy-00 opened this issue Jan 16, 2025 · 5 comments

Comments

@Milkyy-00
Copy link

When you set a spell to a hotkey like F1 (or any other key), holding it down only triggers the spell once. It should keep triggering continuously with some delay when held down.

@Erza
Copy link
Member

Erza commented Jan 20, 2025

Can confirm, and the root cause for the issue seems to be that the entire code that used to handle the hotkey delay (hotkeyDelay from the options), is missing in the reworked keybinds code

@Vyroq
Copy link

Vyroq commented Jan 20, 2025

There is also an issue with resetting hotkeys. If you have hotkeys set, reset them, and then set them again, you wont be able to assign the same hotkey that was set before the reset

@gojtan
Copy link

gojtan commented Jan 20, 2025

I'm having an issue that just pressing the hotkey once triggers the hotkey 2-3 times when you use action bars. If you edit (ctrl+k)-hotkeys it works fine.

@Milkyy-00 Use actionbars and it should solve ur problem :D

@Oen44
Copy link
Collaborator

Oen44 commented Jan 29, 2025

I did that for a reason (holding down key is executing once every 30ms, leading to packet spam and kick by the server). I can update it to use hotkey delay from options.
Which hotkeys should be affected by this? Just Spells? Or using items, equipping and sending text as well?

@Milkyy-00
Copy link
Author

I did that for a reason (holding down key is executing once every 30ms, leading to packet spam and kick by the server). I can update it to use hotkey delay from options. Which hotkeys should be affected by this? Just Spells? Or using items, equipping and sending text as well?

Using items, equipping and sending text, spells. Everything you mentioned.

@Oen44 Oen44 closed this as completed in 6e2d513 Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants