Blocking Calls on Android #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DonnieBLT , any feedbacks for me ? |
|
Looks good! I will review further soon. Thank you. |
|
@DonnieBLT sir, are there any more fixes or should i work on the failing test case, as the ios implementation for it is also ready. |
|
Hi @DonnieBLT sir, just following up on this PR. Let me know if there's anything I can clarify or assist with to help with the review process. Thanks! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR1 for #429
Description
Usage of method channel to invoke blocking functionality, that rejects and silences the incoming calls.
Method Channel Implementation and Control Flow:
-A common method channel made names coms.apps.blt/channel and updated in report_bug as well to ensure clipboard paste still works.
-Asking of permissions
-Handling spam list updates
-Registering a SpamCallBlockerService to run in the background that intercepts the calls.
New Dependencies in gradle folder
The following dependencies are required for this change:
org.greenrobot:eventbus:3.2.com.jakewharton.timber:timber:4.7.1pub.devrel:easypermissions:3.0.0To make sure it properly runs , we currently have to paste this in terminal manually:
" adb shell cmd role add-role-holder android.app.role.CALL_SCREENING com.apps.blt"
In time, i would like to find a programmatic approach for this.
Attached video demo of the fix
Screen.Recording.2024-11-19.at.8.28.03.PM.mov