Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt first implementors draft #17

Merged

Conversation

moratori
Copy link
Member

@moratori moratori commented Jun 24, 2024

Purpose

  • Modifications were made to comply with the implementer draft. The main changes are as shown in the figure below.

ID1

Main changes

Fixes related to compliance with specifications

  • Compliant with the latest specifications for various data structures (adding, deleting, and renaming properties)

  • Added tests for decoding and encoding various data types

Other refactorings

  • Improvements to functions related to CredentialOffer (views, models, view models, etc.)

@moratori moratori changed the title WIP Adopt first implementors draft Adopt first implementors draft Jun 26, 2024
@moratori moratori changed the base branch from main to develop June 28, 2024 04:42
@moratori moratori marked this pull request as draft July 3, 2024 06:32
@moratori moratori marked this pull request as ready for review July 3, 2024 08:12
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryosuke-wakaba ryosuke-wakaba merged commit 1b34dbc into OWND-Project:develop Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants