-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt first implementors draft #17
Merged
ryosuke-wakaba
merged 28 commits into
OWND-Project:develop
from
moratori:adopt-first-implementors-draft
Jul 19, 2024
Merged
Adopt first implementors draft #17
ryosuke-wakaba
merged 28 commits into
OWND-Project:develop
from
moratori:adopt-first-implementors-draft
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… define `CodingKeys` for all data types and not use `.convertFromSnakeCase`.
…undant `CodingKeys` by actively using `keyDecodingStrategy = .convertFromSnakeCase`.
moratori
changed the title
WIP Adopt first implementors draft
Adopt first implementors draft
Jun 26, 2024
ryosuke-wakaba
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Main changes
Fixes related to compliance with specifications
Compliant with the latest specifications for various data structures (adding, deleting, and renaming properties)
Added tests for decoding and encoding various data types
Other refactorings
CredentialOffer
(views, models, view models, etc.)