-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selection of disclosure items #28
Merged
ryosuke-wakaba
merged 15 commits into
OWND-Project:develop
from
moratori:fix-credential-detail-preview
Sep 4, 2024
Merged
Allow selection of disclosure items #28
ryosuke-wakaba
merged 15 commits into
OWND-Project:develop
from
moratori:fix-credential-detail-preview
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture to codable as well.
Allow selection of disclosure items
moratori
changed the title
Fixed to be able to show the preview screen of CredentialDetail.
Allow selection of disclosure items
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comment
ryosuke-wakaba
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix preview screen
credentialData.json
used to display the preview of the CredentialDetail screen has been fixed.ModelData.swift
to ensure resource data is continually maintained.Allow selection of disclosure items
optional
property in theconstraints
of the Input Descriptor, we have made it possible for users to decide whether or not to send claims that are not required to be disclosed.optional
property is defined in 5.1.1 Input Descriptor ObjectDisclosureWithOptionality
has been added to hold the results of the toggle.Disclosure
is directly linked to SD-JWT, so a new data structure has been added.isSubmit
andoptional
ofDisclosureWithOptionality
have the following meanings:isSubmit
optional