Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of disclosure items #28

Merged

Conversation

moratori
Copy link
Member

@moratori moratori commented Aug 21, 2024

Fix preview screen

  • Corruption of the data credentialData.json used to display the preview of the CredentialDetail screen has been fixed.
  • Added tests for ModelData.swift to ensure resource data is continually maintained.

Allow selection of disclosure items

  • By interpreting the optional property in the constraints of the Input Descriptor, we have made it possible for users to decide whether or not to send claims that are not required to be disclosed.
  • Regarding the UI, a toggle button has been added to indicate that selective disclosure is possible. (When the toggle is on, it will be sent. When it is off, it will not be sent.)
  • A new data structure DisclosureWithOptionality has been added to hold the results of the toggle.
    • The existing data structure Disclosure is directly linked to SD-JWT, so a new data structure has been added.
    • The properties isSubmit and optional of DisclosureWithOptionality have the following meanings:
value of isSubmit value of optional semantics
false false This is an unnecessary claim for the verifier and will not be sent.
false true This is an optional claim, and the user does not wish to make any additional disclosures.
true false This is a required claim and should be sent.
true true This is an optional claim, but is sent at the user's discretion.

スクリーンショット 2024-08-27 9 54 22

@moratori moratori changed the title Fixed to be able to show the preview screen of CredentialDetail. Allow selection of disclosure items Aug 27, 2024
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment

tw2023_wallet/Services/OID/OpenIdProvider.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryosuke-wakaba ryosuke-wakaba merged commit 352857e into OWND-Project:develop Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants