Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug: markview overwrites the background of mini.icons in code blocks #230

Open
2 tasks done
mcauley-penney opened this issue Dec 28, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@mcauley-penney
Copy link

Before reporting:

  • Ensure that the issue is reproducable on the main branch.
  • Ensure that there isn't an issue on this(either open or closed).

Problem:

When using icons = "mini" in the code_blocks settings table, the background of the icon area does not match the background of the hl group given in the hl setting. mini.icons advocates to only set fg highlights for its groups, which my colorscheme does and which mini.icons does as well. This all seems to point to Markview setting a background highlight somewhere that contradicts my colorscheme, mini.icons, and my Markview configuration.

Steps to reproduce the issue:

  1. Have lazy.nvim, mini.icons, and markview.nvim installed
  2. Init Markview with the following settings for code blocks:
  {
    "OXY2DEV/markview.nvim",
    ft = "markdown",
    dependencies = {
      "nvim-treesitter/nvim-treesitter",
    },
    opts = {
      code_blocks = {
        icons = "mini",
        language_direction = "left",
        hl = "@markup.raw.block",
        min_width = 30,
        sign = false,
      },
  } 

With these settings, I have

image

Given that mini.icons sets no bg and I'm not setting it anywhere except in the code_blocks config, there should not be two different background colors. In this case, the icons area matches my "Normal" hl group, so I'm assuming that the bg for that group is gotten somewhere and is set for when mini.icons is used.

Expected behavior:

Markview should respect the user's code block hl configuration.

Neovim version:

NVIM v0.11.0-dev-1401+g7e1c1ff7fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants