Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of trapper #1

Open
ObsidianMinor opened this issue Jan 24, 2020 · 0 comments
Open

Remove use of trapper #1

ObsidianMinor opened this issue Jan 24, 2020 · 0 comments
Labels
blocked This issue is blocked by an issue in a library or the Rust compiler

Comments

@ObsidianMinor
Copy link
Owner

trapper isn't required. With some trait design seen in rf/remove-trapper we can replace all usage of trapper with safe Rust.

However as of filing this issue, trying to implement it causes compiler errors with regards to overlapping implementations for packed and unpacked repeated fields. Chalk can fix it, so we have to wait for that.

Playground example.
@ObsidianMinor ObsidianMinor added the blocked This issue is blocked by an issue in a library or the Rust compiler label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This issue is blocked by an issue in a library or the Rust compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ObsidianMinor