From de70d4c77c761195a24b572bf0d3aa10852019b2 Mon Sep 17 00:00:00 2001 From: Rashmil Panchani <32737711+Rashmil-1999@users.noreply.github.com> Date: Tue, 16 Jan 2024 09:36:59 -0600 Subject: [PATCH 1/2] fix water temp display units (#96) * fix water temp display units * add issue link to changelog * change issue number in changelog --- CHANGELOG.md | 6 ++++++ src/components/Explore/LeftSidebar/Station/Environment.tsx | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9ad236e..1f37a1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [unreleased] + +### Fixed + +- Error in displaying temperatures at depths in station details. [#97](https://github.com/Oceans-1876/challenger-portal/issues/97) + ## [1.0.0] - 2023-12-04 ### Added diff --git a/src/components/Explore/LeftSidebar/Station/Environment.tsx b/src/components/Explore/LeftSidebar/Station/Environment.tsx index 341243f..d752733 100644 --- a/src/components/Explore/LeftSidebar/Station/Environment.tsx +++ b/src/components/Explore/LeftSidebar/Station/Environment.tsx @@ -15,7 +15,8 @@ interface Props { const Environment = ({ station }: Props) => { const { tempToUnit, depthToUnit } = React.useContext(DataStateContext); - const tempFromUnit = 'C'; // ? Should this be 'C'? + const tempFromUnit = 'C'; + const tempDepthFromUnit = 'F'; const depthFromUnit = 'fathom'; return ( @@ -103,7 +104,7 @@ const Environment = ({ station }: Props) => { 1 ); const temp = convertUnit( - tempFromUnit as TemperatureUnits, + tempDepthFromUnit as TemperatureUnits, tempToUnit as TemperatureUnits, _temp, 3 From 1619027500f861eea1189735edaf17a4f4b5ce2f Mon Sep 17 00:00:00 2001 From: Rashmil Panchani Date: Wed, 17 Jan 2024 09:09:42 -0600 Subject: [PATCH 2/2] update version number and changelog --- CHANGELOG.md | 2 +- package-lock.json | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f37a1c..e45c71e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [unreleased] +## [1.0.1] - 2024-01-17 ### Fixed diff --git a/package-lock.json b/package-lock.json index edab196..6a2a693 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "challenger-portal", - "version": "1.0.0", + "version": "1.0.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 53d91ef..1714025 100755 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "challenger-portal", - "version": "1.0.0", + "version": "1.0.1", "description": "", "repository": "https://github.com/Oceans-1876/challenger-portal", "main": "src/app.tsx",