Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role uses deprecated keyring.gpg #5

Open
hydrian opened this issue Sep 15, 2024 · 7 comments
Open

Role uses deprecated keyring.gpg #5

hydrian opened this issue Sep 15, 2024 · 7 comments

Comments

@hydrian
Copy link

hydrian commented Sep 15, 2024

Role fails because the task uses apt_key and adds it to the default keyring. Now extra repositories should use their own keyring and reference it the .list file

@tersmitten
Copy link
Member

I don't see anything failing

@tersmitten
Copy link
Member

But I agree that using "your own keyring" is the way to go (nowadays).

@tersmitten
Copy link
Member

But:

Adding a key to /etc/apt/trusted.gpg.d is insecure because it adds the key for all repositories. This is exactly why apt-key had to be deprecated.

@tersmitten
Copy link
Member

@hydrian
Copy link
Author

hydrian commented Sep 23, 2024

Adding a key to /etc/apt/trusted.gpg.d is insecure because it adds the key for all repositories. This is exactly why apt-key had to be deprecated.

I know that /etc/apt/trusted.gpg.d isn't trused. It was a typo. The PR has been updated to use /etc/apt/keyrings.

@tersmitten
Copy link
Member

I prefer consistency (because we have so many roles), can you make it just like the vagrant role?

@hydrian
Copy link
Author

hydrian commented Sep 23, 2024

I'll look into it. Not very familiar with vagrant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants