-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating docs for itemId for Mail and Calendar #2400
Open
vikramtha
wants to merge
5
commits into
main
Choose a base branch
from
vikramtha/updatingitemIDforMailandCalendardocs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AE-MS
reviewed
Jul 11, 2024
@@ -84,7 +84,11 @@ export namespace calendar { | |||
|
|||
/** Open calendar item parameters. */ | |||
export interface OpenCalendarItemParams { | |||
/** An unique base64-encoded string id that represents the event's unique identifier of the calendar item to be opened. */ | |||
/** An unique base64-encoded string id that represents the itemId or messageId. | |||
* The only acceptable id for this itemId is the EWS (Exchange Web Services) ID. However, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AE-MS
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some more docs for the itemId for Mail and Calendar Capability so devs know what type of ID is accepted and how to go from Graph REST Id to EWS Id
Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
Not needed doc change
End-to-end tests added:
No
Additional Requirements
Change file added:
Yes