Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the build script with a codegent crate #417

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Replace the build script with a codegent crate #417

merged 1 commit into from
Aug 24, 2024

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Aug 24, 2024

This lets us generate code in advance, rather than on demand, removing a step from the build process.

Related to #416.

@Ogeon Ogeon added the internal An internal change that will not be shown in release notes label Aug 24, 2024
Copy link

codspeed-hq bot commented Aug 24, 2024

CodSpeed Performance Report

Merging #417 will improve performances by 10.14%

Comparing codegen (a423de9) with master (dcc802a)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark master codegen Change
multiply_3x3 316.7 ns 287.5 ns +10.14%

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (dcc802a) to head (a423de9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   82.90%   82.87%   -0.04%     
==========================================
  Files         132      130       -2     
  Lines       20260    20199      -61     
  Branches    20260    20199      -61     
==========================================
- Hits        16796    16739      -57     
  Misses       3337     3337              
+ Partials      127      123       -4     
Components Coverage Δ
palette 82.93% <100.00%> (-0.04%) ⬇️
palette_derive 81.98% <ø> (ø)

@Ogeon Ogeon merged commit e37e2fe into master Aug 24, 2024
18 of 20 checks passed
@Ogeon Ogeon deleted the codegen branch August 24, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal change that will not be shown in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant