-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in CLI & additional subcommands #90
base: main
Are you sure you want to change the base?
Conversation
OndrejSladky
commented
Feb 12, 2025
•
edited
Loading
edited
- Improved CLI structure
- Improved output headers
- Added subcommands for conversion to/from SPSS and splitting/joining ms.
- Possibility to construct maxone mask during masked superstring construction.
A small glitch in naming the commands: the |
Yeah, I do agree with this, I could rename it to sth like |
Also I'm not sure, if -M should not output the masked-cased superstring maximizing ones instead of the mask, as it feels kinda anoying to run msfa2ms and then ms2msfa to obtain it. |
Yes, I think -M should output a .msfa file as it can then be used in FMSI-memb directly (right, it'd be annoying to run to more commands to obtain it). |
Comments:
|
Unless it's critical for the current submission, we can finalize it next week. |
I will try to use the new CLI and streaming in a new version of the experimental pipeline, hopefully this week. Some renaming is still fine |
@OndrejSladky Could you give us a rough timeline for this? So we know what kind of additional feedback you need from us at each stage. By the way, I’m really looking forward to seeing this integrated! :) |
I'll update the changes you've suggested, likely tomorrow, and then we can iterate other suggestions on how the commands should be named and similar, until we're all satisfied. Then I'll merge (likely including the streaming alg) and bump to v2.0.0 fixing the interface. |
Agree with all of them. mssep sounds good. |
I renamed everything as discussed and also made -M parameter output the masked superstring and not only the mask. |