Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report StopInfo event (develop) #234

Closed
barbeau opened this issue Feb 27, 2015 · 2 comments
Closed

Report StopInfo event (develop) #234

barbeau opened this issue Feb 27, 2015 · 2 comments
Labels
bug enhancement

Comments

@barbeau
Copy link
Member

barbeau commented Feb 27, 2015

We should report the "Loaded StopInfo from X" event, where X is the region name, when the user taps on the icon for which is shown next to the stop name on the ArrivalList Fragment, as discussed in #103.

This was originally incorrectly reported for the event of tapping on the map in the master branch, as discussed in #233.
@barbeau barbeau changed the title Report correct StopInfo event in develop branch Report StopInfo event in develop branch Feb 27, 2015
@barbeau
Copy link
Member Author

barbeau commented Feb 27, 2015

Also, we need to remove the "Loaded StopInfo from X" event from being generated by taps on the map icons in this develop branch as well, just as was done in #233 for master branch.

@barbeau barbeau added the bug label Feb 27, 2015
cagryInside added a commit to cagryInside/onebusaway-android that referenced this issue Mar 4, 2015
@cagryInside
Fix OneBusAway#234 report stop info - Fix # 237 custom url reporting …
1779c63 
…disabled for develop branch
@cagryInside cagryInside mentioned this issue Mar 4, 2015
Merged
cagryInside added a commit to cagryInside/onebusaway-android that referenced this issue Mar 5, 2015
@cagryInside
Fix OneBusAway#232 - Decrease analytics location accuracy threshold t…
9b96e9c 
…o 50m for develop branch

Fix OneBusAway#234 report stop info, Fix # 237 custom url reporting disabled - develop branch
cagryInside added a commit to cagryInside/onebusaway-android that referenced this issue Mar 5, 2015
@cagryInside
Fix OneBusAway#234 report stop info - Fix # 237 custom url reporting …
1cb77f8 
…disabled for develop branch
@barbeau barbeau changed the title Report StopInfo event in develop branch Report StopInfo event (develop) Mar 5, 2015
cagryInside added a commit to cagryInside/onebusaway-android that referenced this issue Mar 6, 2015
@cagryInside
Fix OneBusAway#234 report stop info - Fix # 237 custom url reporting …
c090697 
…disabled for develop branch
barbeau added a commit that referenced this issue Mar 6, 2015
@barbeau
Merge pull request #242 from cagryInside/ga-rebase
263fbce 
Fix #234 report stop info, Fix # 237 custom url reporting disabled - develop branch
@barbeau
Copy link
Member Author

barbeau commented Mar 6, 2015

Fixed in #242

@barbeau barbeau closed this as completed Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barbeau