Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to permissions tables generation #284

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Updates to permissions tables generation #284

merged 3 commits into from
Aug 8, 2024

Conversation

millicentachieng
Copy link
Collaborator

This PR

  • Makes sure that we capture different formatting of the HTML comment metadata preceding the permissions table
  • Adds missing HTML comment metadata to 'included' permissions table
  • Handles exceptions thrown when attempting to deserialize JSON data in the HTML comment metadata
  • Simplifies how we compute where to start looking for the next permissions table after finding the first one

@millicentachieng millicentachieng force-pushed the update-permissions-tables-gen branch from 48f6bbb to 9d3b0a3 Compare August 8, 2024 00:02
@millicentachieng millicentachieng merged commit 7b6c9ce into master Aug 8, 2024
5 checks passed
@millicentachieng millicentachieng deleted the update-permissions-tables-gen branch August 8, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millicentachieng @andrueastman